Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-child-process-execsync flaky on AIX #25031

Closed
wants to merge 1 commit into from
Closed

test: mark test-child-process-execsync flaky on AIX #25031

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 14, 2018

Contributors, please 👍 here to fast-track.

Refs: #24921

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 14, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1941/pipeline

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19506/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2018
@Trott
Copy link
Member Author

Trott commented Dec 14, 2018 •
edited
Loading

Windows CI Rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/23280/ ✔️

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

CI is good but this needs one more Collaborator approval to fast-track.

@Trott
Copy link
Member Author

Trott commented Dec 14, 2018

Landed in d0c240f

@Trott Trott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: mark test-child-process-execsync flaky on AIX
d0c240f 
Refs: nodejs#24921

PR-URL: nodejs#25031
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott @BethGriggs
test: mark test-child-process-execsync flaky on AIX
a4ef54a 
Refs: #24921

PR-URL: #25031
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-child-process-execsync flaky on AIX
54408a2 
Refs: nodejs#24921

PR-URL: nodejs#25031
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: mark test-child-process-execsync flaky on AIX
89b6d1b 
Refs: #24921

PR-URL: #25031
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: mark test-child-process-execsync flaky on AIX
1b3f1ca 
Refs: #24921

PR-URL: #25031
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: mark test-child-process-execsync flaky on AIX
15d3d3d 
Refs: #24921

PR-URL: #25031
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott Trott deleted the aix-flaky-execsync branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bmeck bmeck bmeck approved these changes

Assignees
No one assigned
Labels
aix Issues and PRs related to the AIX platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @bmeck @cjihrig @richardlau @gireeshpunathil @BethGriggs