build: make lint-addon-docs run only if needed #24993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
richardlau
approved these changes
Dec 12, 2018
joyeecheung
approved these changes
Dec 12, 2018
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does.
danbev
force-pushed
the
build-lint-addon-docs
branch
from
e040efb
to
9693581
Compare
|
Re-run of failing node-test-commit-linux-containered ✔️ |
thefourtheye
approved these changes
Dec 13, 2018
BridgeAR
added
the
author ready
|
Landed in e7c3a1b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 15, 2018
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: nodejs#24993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: #24993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: nodejs#24993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: #24993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: #24993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Currently, the lint-addon-docs targets recipe will always be run. This commit makes lint-addon-docs a phony target and adds a new target named tools/.doclintstamp what will be an actual file, similar to what the lint-cpp target does. PR-URL: #24993 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
lint-addon-docstargets recipe will always be run.This commit makes
lint-addon-docsa phony target and adds a new target namedtools/.doclintstampwhat will be an actual file, similar to what thelint-cpptarget does.
@nodejs/build-files
make -j4 test(UNIX), orvcbuild test(Windows) passes