-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove bad link to irc info #24967
Conversation
Remove a link that no longer appears to point to information about Node.js IRC channels.
I'm open to replacing the link if someone has a suitable alternative. The current link is actually blocked at work for being pornographic (and a colleague has confirmed that it's not an inaccurate categorization). WHOIS suggests the domain was recently created/updated (perhaps the old registration expired?): https://whois.icann.org/en/lookup?name=nodeirc.info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this link is definitely not something that should be in our readme
Node Collaborators, 👍 here to fast-track |
As alternative, we can consider to using webchat: which is used in website: https://nodejs.org/en/get-involved/ |
@watilde the current link is |
Landed in 8c290fd |
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: nodejs#24967 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: nodejs#24967 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Remove a link that no longer appears to point to information about Node.js IRC channels. PR-URL: #24967 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Remove a link that no longer appears to point to information about
Node.js IRC channels.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes