Revert "stream: make .destroy() interact better with write queue"
#24905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3f02d0. Fixes: nodejs#24456
The issue was resolved by reverting d3f02d0.
nodejs-github-bot
added
the
stream
cjihrig
approved these changes
Dec 8, 2018
|
Fixes: #24456 |
|
Stress test on master: https://ci.nodejs.org/job/node-stress-single-test/2122/ Stress test on this PR: https://ci.nodejs.org/job/node-stress-single-test/2123/ In both cases: RUN_TESTS: -j1 parallel/test-stream-pipeline |
|
Failure on macOS in CI seems relevant. Maybe this exchanges one flaky test for another... 06:52:42 not ok 1867 parallel/test-tls-hello-parser-failure
06:52:42 ---
06:52:42 duration_ms: 0.220
06:52:42 severity: fail
06:52:42 exitcode: 1
06:52:42 stack: |-
06:52:42 events.js:174
06:52:42 throw er; // Unhandled 'error' event
06:52:42 ^
06:52:42
06:52:42 Error [ERR_STREAM_DESTROYED]: Cannot call write after a stream was destroyed
06:52:42 at doWrite (_stream_writable.js:411:19)
06:52:42 at clearBuffer (_stream_writable.js:545:7)
06:52:42 at onwrite (_stream_writable.js:470:7)
06:52:42 at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:61:12)
06:52:42 Emitted 'error' event at:
06:52:42 at errorOrDestroy (internal/streams/destroy.js:98:12)
06:52:42 at onwriteError (_stream_writable.js:430:5)
06:52:42 at onwrite (_stream_writable.js:461:5)
06:52:42 at doWrite (_stream_writable.js:411:11)
06:52:42 at clearBuffer (_stream_writable.js:545:7)
06:52:42 at onwrite (_stream_writable.js:470:7)
06:52:42 at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:61:12)
06:52:42 ... |
|
@Trott I think you’d need to revert more than one PR… this would definitely be unfortunate :/ |
|
Plus, this shouldn’t get a |
|
Applied WIP label as this should not land, certainly not as-is. :-( |
|
Closing in favor of #24926. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverted commit introduced (or greatly exacerbated) the unreliability of test-stream-pipeline-http2. Would be happy to see a fix, but in absence of that, a revert seems in order.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes