v8.14.1 proposal #24832
Merged
v8.14.1 proposal #24832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only changes to src/base/debug/stack_trace_posix.cc included
Original commit message:
Fixes to V8 GN build process on aix platform
src/base/debug/stack_trace_posix.cc: suppressed unused function warnings
for functions DemangleSymbols, OutputPointer(in order to compile with
-Werror flag)
test/cctest/test-isolate-independent-builtins.cc: corrections to make
ByteInText test case compatible with aix. (affects aix only)
Change-Id: I49e45e63545404c77aaed3f51b26557f6f03455e
Reviewed-on: https://chromium-review.googlesource.com/927484
Reviewed-by: Jakob Gruber <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Jakob Gruber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#52071}
PR-URL: #23958
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: George Adams <[email protected]>
Original commit message:
ppc64, aix: Pass CallFrequency object by const reference to avoid value copy error.
Bug: v8:8193
GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976
Change-Id: I0d4efca4da03ef82651325e15ddf2160022bc8de
Reviewed-on: https://chromium-review.googlesource.com/1228633
Reviewed-by: Michael Starzinger <[email protected]>
Reviewed-by: Daniel Clifford <[email protected]>
Reviewed-by: Junliang Yan <[email protected]>
Commit-Queue: Junliang Yan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56275}
PR-URL: #23958
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: George Adams <[email protected]>
Floating this patch since the code does not exist upstream anymore. deps/v8/testing/gtest.gyp: Supperss -Wnonnull-compare, -Waddress warnings for deps/v8/testing/gtest project; deps/v8/src/compiler/store-store-elimination.cc, deps/v8/src/conversions.cc: Suppress unused function warnings in order to compile with newer (>4.8.5) gcc on Aix. PR-URL: #23958 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: George Adams <[email protected]>
PR-URL: #23745 Fixes: #9822 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #23787 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #23678 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
PR-URL: #23771 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #23768 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Creating directory symlinks on Windows require 'dir' parameter to be provided. Fixes: #23596 PR-URL: #23691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #12572 Refs: #16240 PR-URL: #23746 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: #19192 PR-URL: #23772 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Fixes: #21635 PR-URL: #23762 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Moving @phillipj to emeriti as he has not been an active collaborator for a long time, and will not have the opportunity to do so in the near future. PR-URL: #23790 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ICU 62.1 had a bug where certain orders of operations would not work with the minimum significant digit setting. Fixed in ICU 63.1. Applied the following patch from v8. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503 ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20063 Fixes: #22156 PR-URL: #23764 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code duplication in SecureContext::Initialize. PR-URL: #23687 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #23605 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23800 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
PR-URL: #23763 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Refs: ayojs/ayo#14 Refs: ayojs/ayo#75 Co-authored-by: Jeremiah Senkpiel <[email protected]> PR-URL: #21059 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Run `make lint-md-build` to install the markdown linter. PR-URL: #21215 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Remove macOS-specific steps, and reduce warnings due to compilation with clang. PR-URL: #21459 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #22417 Reviewed-By: George Adams <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
- In release guide - In Travis config Refs: #20109 PR-URL: #22991 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Use Travis-CI to check the formatting of the first commit in a pull request. This will hopefully reduce formatting errors and nits about them in pull requests. PR-URL: #22452 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Steven R Loomis <[email protected]>
Use $TRAVIS_COMMIT_RANGE in .travis.yml to avoid merge commits in some situations. Refs: #23307 (comment) PR-URL: #23397 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Check that $TRAVIS_COMMIT_RANGE is set before trying to lint commit messages in Travis CI. Refs: #23572 (comment) Refs: #22842 (comment) PR-URL: #23725 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Clarify in Travis results that the commit message linting is for the commit message and not something else. PR-URL: #23742 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #23864 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #23829 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
richardlau
reviewed
Dec 4, 2018
|
Just for awareness, for Node.js 8.x the start of maintenance date was brought forward from April 2019 to January 2019 (nodejs/Release#376), so this is the last planned active release of Node.js 8.x before it enters maintenance (during which
). |
BethGriggs
force-pushed
the
v8.14.1-proposal
branch
from
1f27133
to
5c7cb53
Compare
BethGriggs
added a commit
that referenced
this pull request
Dec 4, 2018
Notable changes: * Coming soon PR-URL: #24832
|
CI: https://ci.nodejs.org/job/node-test-pull-request/19206/ [Passed] |
|
@BethGriggs would you be so kind and include #24786 in this release? The longer the change stays in an release, the less it makes sense to actually revert it. |
Fixes: #24105 PR-URL: #24869 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Description inspired by dev tools reference and inspector err messages Added: * intro * console.debug() * console.dirxml() * console.markTimeline() * console.profile() * console.profileEnd() * console.table() * console.timeStamp() * console.timeline() * console.timelineEnd() PR-URL: #17004 Fixes: #16755 Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
It was not intended to change the `assert.doesNotThrow()` message with #23223. This reverts the breaking behavior to the one before. PR-URL: #24786 Refs: #23223 Reviewed-By: Beth Griggs <[email protected]>
Currently the order of error / closing of an h2 stream is consistent in 10.x, 11.x, and master. There appears to be an unexpected behavior difference in 8.x. This test will be used to bisect the commit that will fix this behavior change and ensure there are no future regressions. PR-URL: #24685 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Correct sequence of emitting `error` and `close` events for a `Http2Stream`. PR-URL: #24789 Refs: #22850 Refs: #24685 Fixes: #24559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
force-pushed
the
v8.14.1-proposal
branch
from
5c7cb53
to
9fc8d9a
Compare
BethGriggs
added a commit
that referenced
this pull request
Dec 11, 2018
|
CI2: https://ci.nodejs.org/job/node-test-pull-request/19424 [Passed, Windows passed on rerun] |
MylesBorins
force-pushed
the
v8.14.1-proposal
branch
from
9fc8d9a
to
ab0abb1
Compare
|
As I'll be the one promoting this release I've gone ahead and updating the original post and the changelog to reflect this. Kicked off the ci-release build and will promote the assets in the a.m. |
MylesBorins
force-pushed
the
v8.14.1-proposal
branch
from
ab0abb1
to
187694e
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 18, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Notable changes:
* **assert**:
- revert breaking change (Ruben Bridgewater)
[nodejs#24786](nodejs#24786)
* **http2**:
- fix sequence of error/close events (Gerhard Stoebich)
[nodejs#24789](nodejs#24789)
PR-URL: nodejs#24832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-12-18, Version 8.14.1 'Carbon' (LTS), @MylesBorins prepared by @BethGriggs
Notable changes
Commits
a8402fe1c8] - build: only check REPLACEME & DEP...X for releases (Rod Vagg) #2457526743369d3] - build: improve Travis CI settings (Timothy Gu) #214591da04c208d] - build: install markdown linter for travis (Richard Lau) #212157612024939] - build: initial .travis.yml implementation (Anna Henningsen) #21059f70e79a7b2] - build: allow for overwriting of use_openssl_def (Shelley Vohr) #2376315d1f67c60] - build,doc: remove outdatedlint-md-build(Michaël Zasso) #2299185a6daeaef] - build,meta: switch to gcc-4.9 on travis (Refael Ackermann) #23778313ef6fa73] - build,tools: tweak the travis config (Refael Ackermann) #2241722b41495ea] - child_process: handle undefined/null for fork() args (Shobhit Chittora) #22416499605618b] - crypto: add SET_INTEGER_CONSANT macro (Daniel Bevenius) #2368734d91296df] - deps: icu: apply workaround patch (Steven R. Loomis) #2376450347297a1] - deps: cherry-pick d2e0166 from V8 upstream (Vasili Skurydzin) #239589bedae5266] - deps: cherry-pick 6bc4bfe from V8 upstream (Vasili Skurydzin) #239584f3c9e6aab] - deps,v8: fix gyp build on Aix platform (Vasili Skurydzin) #239586d8c65e574] - doc: update to adding listens on SIGUSR1 (willhayslett) #1970933b7c50036] - doc: remove "if provided" for optional arguments (Rich Trott) #19690216e7da8c5] - doc: do not identify string as "JavaScript string" (Rich Trott) #1968917e84217c7] - doc: fix grammar error in process.md (Kenji Okamoto) #1964106daf5276f] - doc: remove use of "random port" re dgram send (Thomas Hunter II) #19620bf95392e86] - doc: improve assert legacy text (Rich Trott) #19622e48cc3c403] - doc: remove confusing note about child process stdio (Anna Henningsen) #195529d249bf6d5] - doc: add BethGriggs to collaborators (Beth Griggs) #19610c3ecf05b01] - doc: documentmake docopen(Ayush Gupta) #193218338700d05] - doc: add directory structure in writing-tests.md (juggernaut451) #1880263d8632611] - doc: add types for someprocessproperties (Vse Mozhet Byt) #19571b2fc3b556c] - doc: fix n-api example string (Steven R. Loomis) #19205d79e7d6e89] - doc: minor improvements to buffer.md (Rich Trott) #1954706491482f8] - doc: update child_process.md (Ari Leo Frankel) #190754db289ca17] - doc: move StackOverflow to unofficial section (josephleon) #19416f5683a9a6d] - doc: correct async_hooks resource names (Gerhard Stoebich) #24684ffe1f8033c] - doc: sort bottom-of-file markdown links (Sam Roberts) #2468278d9a5e6e4] - doc: address bits of proof reading work (Jagannath Bhat) #23978d1eebb2e43] - doc: revise COLLABORATOR_GUIDE.md (Rich Trott) #23990003eb0c8e1] - doc: simplify CODE_OF_CONDUCT.md (Rich Trott) #23989c1723c8bca] - doc: add branding to style guide (Rich Trott) #239678bb67a1fb9] - doc: use Node.js instead of Node (Rich Trott) #2396773e0bb1f52] - doc: fix typographical issues (Denis McDonald) #239706d76f852a9] - doc: add documentation for http.IncomingMessage$complete (James M Snell) #239143025f351db] - doc: remove mailing list (Rich Trott) #239322459e150bb] - doc: add note about ABI compatibility (Myles Borins) #2223727b35833bd] - doc: make example more clarified in cluster.md (ZYSzys) #239310d4de59967] - doc: simplify valid security issue descriptions (Rich Trott) #238819afdc09f98] - doc: simplify path.basename() on POSIX and Windows (ZYSzys) #238643f2a01688d] - doc: add review suggestions to require() (erickwendel) #23605f037942fe7] - doc: move @phillipj to emeriti (Phillip Johnsen) #23790e5f75cf82e] - doc: add note about removeListener order (James M Snell) #237620ff88a3510] - doc: document ACL limitation for fs.access on Windows (James M Snell) #2377232ae851710] - doc: document that addMembership must be called once in a cluster (James M Snell) #23746e2d2ce6706] - doc: remove reference to sslv3 in tls.md (James M Snell) #237458afbd5ce41] - lib: fix a typo in lib/timers "read through" (wangzengdi) #19666fa12532000] - lib: remove useless cwd in posix.resolve (ZYSzys) #23902e8dbd09414] - src: use "constants" string instead of creating new one (Ouyang Yadong) #238945e09a3d4ed] - test: test process.setuid for bad argument types (Divyanshu Singh) #19703970164f3a8] - test: improve assert message (fatahn) #19629086570e4e1] - test: remove third argument from call to assert.strictEqual() (Forrest Wolf) #19659a7b3274af4] - test: fix flaky test-cluster-send-handle-twice (Rich Trott) #197001bda58289a] - test: rename regression tests more expressively (Ujjwal Sharma) #19668bd9cc92e8d] - test: remove 3rd argument from assert.strictEqual (Arian Santrach) #197073ca10faf00] - test: use createReadStream instead of ReadStream (Daniel Bevenius) #196368a546e822d] - test: removed default message from assert.strictEqual (jaspal-yupana) #19660a62df1b379] - test: refactor test-net-dns-error (Luigi Pinca) #196408a0ecf4360] - test: refactor test-http-expect-continue (Rich Trott) #196250cbe813e90] - test: update link according to NIST bibliography (Tobias Nießen) #19593ea1fda6228] - test: remove third param from assert.strictEqual ([email protected]) #1953618c4e5e886] - test: remove message from assert.strictEqual() (willhayslett) #19525146c488bf5] - test: refactor parallel/test-tls-ca-concat.js (juggernaut451) #190928fa5bd3761] - test: rename regression tests file names (Ujjwal Sharma) #19332d34ade8755] - test: fix strictEqual arguments order (Esteban Sotillo) #239566ae07a9248] - test: add property for RangeError in test-buffer-copy (mritunjaygoutam12) #23968b1e6de80c1] - test: fix regression when compiled with FIPS (Adam Majer) #23871d0368b8245] - test: fix strictEqual() argument order (Loic) #238293a864d716e] - test: fix strictEqual() arguments order (Nolan Rigo) #23800e7a573a9e2] - test: fix test-require-symlink on Windows (Bartosz Sosnowski) #23691ac91346776] - test: fix strictEqual() argument order (Romain Lanz) #237680f98c4926a] - test: fix strictEqual() arguments order (Thomas GENTILHOMME) #2377173d19b1516] - test: ensure openssl version prints correctly (Sam Roberts) #23678544e64d68d] - test: fix assertion arguments order (Elian Gutierrez) #23787e84c01d1f3] - tools: update alternative docs versions (Richard Lau) #2398002209c5fa7] - tools: clarify commit message linting (Rich Trott) #2374222043ccb84] - tools: do not lint commit message if var undefined (Rich Trott) #237252a8a28c436] - tools: make Travis commit linting more robust (Rich Trott) #23397c15d236545] - tools: apply linting to first commit in PRs (Rich Trott) #22452