Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove finalized_ member from Hash class #24822

Closed
wants to merge 1 commit into from
Closed

src: remove finalized_ member from Hash class #24822

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 4, 2018

This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: remove finalized_ member from Hash class
de5e8dd 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.
@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1820/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 4, 2018
@danbev
Copy link
Contributor Author

danbev commented Dec 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19177/

@danbev
Copy link
Contributor Author

danbev commented Dec 7, 2018

Landed in cbf0e5a.

@danbev danbev closed this Dec 7, 2018
@danbev danbev deleted the crypto_hash_remove_finalized_var branch December 7, 2018 04:47
danbev added a commit that referenced this pull request Dec 7, 2018
@danbev
src: remove finalized_ member from Hash class
cbf0e5a 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 7, 2018
@danbev @MylesBorins
src: remove finalized_ member from Hash class
9b000e5 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@danbev @refack
src: remove finalized_ member from Hash class
4bfc289 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: nodejs#24822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@danbev @BethGriggs
src: remove finalized_ member from Hash class
7455597 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@danbev @BethGriggs
src: remove finalized_ member from Hash class
79dfe8b 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@danbev @rvagg
src: remove finalized_ member from Hash class
8728bc8 
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.

PR-URL: #24822
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @nodejs-github-bot @addaleax @lpinca @cjihrig @joyeecheung @BethGriggs