-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspector, tracing: Make sure messages are sent on a main thread #24814
Conversation
@ofrobots |
Looks like there's a race condition that surfaces on Windows. |
CI is now passing: https://ci.nodejs.org/job/node-test-pull-request/19946/ I will update the commit title and will rebase the change. I also have a follow-up CL that fixes the problem that the bad test case identified. |
@nodejs/v8-inspector @nodejs/trace-events |
Any news on when this PR could be merged (as well was #24945) ? Currently the inspector based |
The only CI failure is coming from a flaky test that only fails on a single bot. |
Fixes: #23185 PR-URL: #24814 Reviewed-By: James M Snell <[email protected]>
Fixes: #23185
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes