tools: prepare tools/test.py for Python 3 #24799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
Trott
approved these changes
Dec 6, 2018
Trott
added
the
python
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19266/ ✔️ |
danbev
approved these changes
Dec 7, 2018
|
@nodejs/python This could use another reviewer. |
|
Landed in 29204f4. |
|
@Trott Sorry, I just noticed your comment after merging 😞 |
danbev
pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
No, you were right to merge it. Your approval came in seconds before my comment, making it obsolete just as I was making it. 😆 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24799 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes