Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: compat always return this on .end() #24795

Closed
wants to merge 1 commit into from
Closed

http2: compat always return this on .end() #24795

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Dec 3, 2018 •
edited
Loading

Always return this. Looks like a typo?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Dec 3, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Dec 3, 2018

@ronag would you be so kind and add a test for this? Thanks :-)

@ronag
Copy link
Member Author

ronag commented Dec 3, 2018

Dammit! haha, yes, will do

apapirovski
apapirovski approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test but the change is good.

@lpinca
Copy link
Member

lpinca commented Mar 11, 2019

@ronag I think this can be closed in favor of #24346 right?

@ronag ronag closed this Mar 11, 2019
@ronag
Copy link
Member Author

ronag commented Mar 11, 2019

Yes, this must really have annoyed me if I fixed it twice :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @BridgeAR @lpinca @apapirovski @trivikr @nodejs-github-bot