doc,meta: update PR approving info #24561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
meta
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Trott
approved these changes
Nov 22, 2018
apapirovski
approved these changes
Nov 22, 2018
|
Landed in 9c7b87b |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 22, 2018
Refs: nodejs#22255 PR-URL: nodejs#24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 24, 2018
Refs: #22255 PR-URL: #24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Refs: #22255 PR-URL: #24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
Refs: #22255 PR-URL: #24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Refs: nodejs#22255 PR-URL: nodejs#24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Refs: #22255 PR-URL: #24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Refs: #22255 PR-URL: #24561 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
This was referenced Jan 29, 2019
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: #22255