Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixed the arguments order in assert.strictEqual #24431

Closed
wants to merge 1 commit into from
Closed

test: fixed the arguments order in assert.strictEqual #24431

wants to merge 1 commit into from

Conversation

apoorvanand
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM.

Commit message should start with test: fix ...

@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@Trott
Copy link
Member

Trott commented Nov 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18737/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 19, 2018
@apoorvanand @Trott
test: fix the arguments order in assert.strictEqual
b4af0c4 
PR-URL: nodejs#24431
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 19, 2018

Landed in b4af0c4.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 19, 2018
targos pushed a commit that referenced this pull request Nov 19, 2018
@apoorvanand @targos
test: fix the arguments order in assert.strictEqual
7f88711 
PR-URL: #24431
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@hiroppy hiroppy mentioned this pull request Nov 24, 2018
Closed
62 tasks
sigwyg pushed a commit to sigwyg/node that referenced this pull request Nov 24, 2018
test: fix the arguments order in assert.strictEqual
9053daf 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431
@sigwyg sigwyg mentioned this pull request Nov 24, 2018
Closed
4 tasks
sigwyg pushed a commit to sigwyg/node that referenced this pull request Nov 24, 2018
test: fix the arguments order in assert.strictEqual
a2b6f20 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431
@sigwyg sigwyg mentioned this pull request Nov 24, 2018
Closed
4 tasks
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@apoorvanand @rvagg
test: fix the arguments order in assert.strictEqual
5d66310 
PR-URL: #24431
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@Trott
test: fix the arguments order in assert.strictEqual
d12d023 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431

PR-URL: nodejs#24624
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
targos pushed a commit that referenced this pull request Nov 29, 2018
@targos
test: fix the arguments order in assert.strictEqual
603bc27 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

PR-URL: #24624
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Dec 8, 2018
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@apoorvanand @codebytere
test: fix the arguments order in assert.strictEqual
359004c 
PR-URL: #24431
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@apoorvanand @refack
test: fix the arguments order in assert.strictEqual
b8be997 
PR-URL: nodejs#24431
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
test: fix the arguments order in assert.strictEqual
e3d045d 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: nodejs#24431

PR-URL: nodejs#24624
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@apoorvanand @codebytere
test: fix the arguments order in assert.strictEqual
5ad224d 
PR-URL: #24431
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@BethGriggs
test: fix the arguments order in assert.strictEqual
288d60c 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

PR-URL: #24624
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@rvagg
test: fix the arguments order in assert.strictEqual
9231b5f 
I working at "Code and Learn" on Node fest 2018 in Japan.

Refs: #24431

PR-URL: #24624
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@oyyd oyyd oyyd approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@apoorvanand @targos @Trott @jasnell @cjihrig @oyyd @gireeshpunathil @trivikr @nodejs-github-bot