src: pass Isolate where necessary #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ Utf8Value::Utf8Value(v8::Handle<v8::Value> value) | |||
| if (value.IsEmpty()) | |||
| return; | |||
|
|
|||
| v8::Local<v8::String> val_ = value->ToString(); | |||
| v8::Local<v8::String> val_ = value->ToString(v8::Isolate::GetCurrent()); | |||
There was a problem hiding this comment.
Kind of unfortunate but something for another PR.
There was a problem hiding this comment.
Ah yeah. Was going to add a TODO for that as well.
|
LGTM |
trevnorris
added a commit
that referenced
this pull request
Jan 7, 2015
Due to a recent V8 upgrade, more methods require Isolate as an argument. PR-URL: #244 Reviewed-by: Ben Noordhuis <[email protected]>
trevnorris
added a commit
that referenced
this pull request
Jan 7, 2015
Initial attempt to remove all uses of Isolate::GetCurrent(). Still exists a few locations, but this works out a heavy usage. PR-URL: #244 Reviewed-by: Ben Noordhuis <[email protected]>
|
Thanks. Landed in d553386 and cbf76c1. |
This was referenced Jun 28, 2021
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few fix-ups from the latest V8 update. Noting major.
R=@bnoordhuis