-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update to [email protected] #24391
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule.
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)
Trott
added
doc
Issues and PRs related to the documentations.
tools
Issues and PRs related to the tools directory.
labels
Nov 16, 2018
@nodejs/linting @nodejs/documentation This can use some reviews. |
jasnell
approved these changes
Nov 19, 2018
watilde
approved these changes
Nov 19, 2018
Landed in dafd76c...3cac82f |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: nodejs#24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 19, 2018
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: nodejs#24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 19, 2018
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 19, 2018
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
This was referenced Dec 7, 2018
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jan 13, 2019
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: nodejs#24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: nodejs#24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Minor formatting adjustments to two changelog files in preparation for a markdown lint rule. PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jan 29, 2019
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.) PR-URL: #24391 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)
Minor formatting adjustments to two changelog files in preparation for the new markdown lint rule.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes