Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update to [email protected] #24391

Closed
wants to merge 2 commits into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 16, 2018

Adds linting for number of spaces after a list indicator. (Expects exactly 1 space.)

Minor formatting adjustments to two changelog files in preparation for the new markdown lint rule.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)
@Trott Trott added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Nov 16, 2018
@Trott
Copy link
Member Author

Trott commented Nov 18, 2018

@nodejs/linting @nodejs/documentation This can use some reviews.

@Trott
Copy link
Member Author

Trott commented Nov 19, 2018

Landed in dafd76c...3cac82f

@Trott Trott closed this Nov 19, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: nodejs#24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Nov 19, 2018
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: nodejs#24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request Nov 19, 2018
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request Nov 19, 2018
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
codebytere pushed a commit that referenced this pull request Jan 13, 2019
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 13, 2019
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: nodejs#24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Adds linting for number of spaces after a list indicator. (Expects
exactly 1 space.)

PR-URL: nodejs#24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
Minor formatting adjustments to two changelog files in preparation for a
markdown lint rule.

PR-URL: #24391
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants