Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: make Http2ServerResponse#end() always return this #24346

Closed
wants to merge 1 commit into from
Closed

http2: make Http2ServerResponse#end() always return this #24346

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 13, 2018

Http2Response.end can return false instead of this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 13, 2018
@ronag ronag force-pushed the http2-compat-end-return-this branch from 0ab5abc to 11e7f62 Compare November 13, 2018 22:34
@lpinca
Copy link
Member

lpinca commented Mar 10, 2019

cc: @nodejs/http2

@lpinca lpinca changed the title Http2 compat end return this http2: Make Http2ServerResponse#end() always return this Mar 10, 2019
@lpinca
Copy link
Member

lpinca commented Mar 10, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21388/

mcollina
mcollina approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21389/

@lpinca lpinca mentioned this pull request Mar 11, 2019
Closed
4 tasks
@lpinca lpinca changed the title http2: Make Http2ServerResponse#end() always return this http2: make Http2ServerResponse#end() always return this Mar 11, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@ronag @BridgeAR
http2: Http2ServerResponse.end() should always return self
90fdf1b 
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR
Copy link
Member

Landed in 90fdf1b 🎉

@BridgeAR BridgeAR closed this Mar 12, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@ronag @BridgeAR
http2: Http2ServerResponse.end() should always return self
348d9a6 
PR-URL: #24346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@ronag @BridgeAR
http2: Http2ServerResponse.end() should always return self
df4cb3c 
PR-URL: #24346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@ronag @BridgeAR
http2: Http2ServerResponse.end() should always return self
0225a45 
PR-URL: nodejs#24346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@ronag @BridgeAR
http2: Http2ServerResponse.end() should always return self
6adcc6f 
PR-URL: #24346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@ronag @BethGriggs
http2: Http2ServerResponse.end() should always return self
59b348e 
PR-URL: #24346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ronag @lpinca @addaleax @BridgeAR @mcollina @cjihrig @nodejs-github-bot