Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update remark version to v10 from v8 #24333

Closed
wants to merge 3 commits into from
Closed

tools: update remark version to v10 from v8 #24333

wants to merge 3 commits into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Nov 13, 2018

Including the below two updates:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@watilde build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1592/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 13, 2018
@richardlau
Copy link
Member

I think we also need to regenerate tools/lint-md.js.

@watilde
Copy link
Member Author

watilde commented Nov 13, 2018

@richardlau That's right. Apparently, lint-md-rollup was always using the latest version by using npm up and I replaced it with npm install to bring the versions under a control. Then I regenerated tools/lint-md.js.

cc @refack

refack
refack approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refack
Copy link
Contributor

refack commented Nov 13, 2018

I saw make lint-md-rollup as an all-in-one recepie to update lint-md.js. But I agree it makes sense to have a way that deterministically reproduces it...

@watilde
Copy link
Member Author

watilde commented Nov 14, 2018

ci: https://ci.nodejs.org/job/node-test-pull-request/18597/

@danbev
Copy link
Contributor

danbev commented Nov 16, 2018

Landed in 62d053b, 195b7c2, and eeed6d9.

@danbev danbev closed this Nov 16, 2018
danbev pushed a commit that referenced this pull request Nov 16, 2018
@watilde @danbev
tools: update remark version to v10 from v8
eeed6d9 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
danbev pushed a commit that referenced this pull request Nov 16, 2018
@watilde @danbev
tools: update remark-lint to v6.0.3 from v6.0.2
195b7c2 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
danbev pushed a commit that referenced this pull request Nov 16, 2018
@watilde @danbev
tools: fix make lint-md-rollup and run it
62d053b 
PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@watilde watilde deleted the feature/update-remark branch November 16, 2018 05:10
targos pushed a commit that referenced this pull request Nov 18, 2018
@watilde @targos
tools: update remark version to v10 from v8
f6ea416 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@watilde @targos
tools: update remark-lint to v6.0.3 from v6.0.2
9bdc1fb 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@watilde @targos
tools: fix make lint-md-rollup and run it
e327b77 
PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@watilde @rvagg
tools: update remark version to v10 from v8
b9a4bc1 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@watilde @rvagg
tools: update remark-lint to v6.0.3 from v6.0.2
7ffc8b7 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@watilde @rvagg
tools: fix make lint-md-rollup and run it
5748e86 
PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@watilde @codebytere
tools: update remark version to v10 from v8
16f0f10 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@watilde @codebytere
tools: update remark-lint to v6.0.3 from v6.0.2
ba10955 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 12, 2019
@watilde @codebytere
tools: fix make lint-md-rollup and run it
c774baf 
PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@watilde @codebytere
tools: update remark version to v10 from v8
2bed68f 
Including the below two updates:
+ https://github.com/remarkjs/remark/releases/tag/9.0.0
+ https://github.com/remarkjs/remark/releases/tag/10.0.0

PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@watilde @codebytere
tools: update remark-lint to v6.0.3 from v6.0.2
e8e93df 
PR-URL: #24333
Refs: https://github.com/remarkjs/remark-lint/releases/tag/6.0.3
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@watilde @codebytere
tools: fix make lint-md-rollup and run it
21843c7 
PR-URL: #24333
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@watilde @nodejs-github-bot @richardlau @refack @danbev