From 57778b7756320b4afb169a76d7928796c69ebd14 Mon Sep 17 00:00:00 2001 From: razvanbh Date: Tue, 6 Nov 2018 19:27:01 +0200 Subject: [PATCH 1/3] test: add process no deprecation --- .../test-child-process-no-deprecation.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 test/parallel/test-child-process-no-deprecation.js diff --git a/test/parallel/test-child-process-no-deprecation.js b/test/parallel/test-child-process-no-deprecation.js new file mode 100644 index 00000000000000..58ce3b0145af5a --- /dev/null +++ b/test/parallel/test-child-process-no-deprecation.js @@ -0,0 +1,17 @@ +'use strict'; +const common = require('../common'); +process.noDeprecation = true; + +if (process.argv[2] === 'child') { + process.emitWarning('Something else is deprecated.', 'DeprecationWarning'); +} else { + // parent process + const spawn = require('child_process').spawn; + + // spawn self as child + const child = spawn(process.argv[0], [process.argv[1], 'child']); + + child.stderr.setEncoding('utf8'); + child.stderr.on('data', common.mustNotCall()); +} + From 4e1d3094cf529276ee4ea0741c0db456adebb400 Mon Sep 17 00:00:00 2001 From: razvanbh Date: Wed, 7 Nov 2018 01:15:56 +0200 Subject: [PATCH 2/3] test: removed trailing newline --- test/parallel/test-child-process-no-deprecation.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/parallel/test-child-process-no-deprecation.js b/test/parallel/test-child-process-no-deprecation.js index 58ce3b0145af5a..20973302ddfbbb 100644 --- a/test/parallel/test-child-process-no-deprecation.js +++ b/test/parallel/test-child-process-no-deprecation.js @@ -14,4 +14,3 @@ if (process.argv[2] === 'child') { child.stderr.setEncoding('utf8'); child.stderr.on('data', common.mustNotCall()); } - From c0be069553dd5eee51b84cd3f985b1431296d082 Mon Sep 17 00:00:00 2001 From: razvanbh Date: Sat, 10 Nov 2018 21:47:33 +0200 Subject: [PATCH 3/3] Implemented suggested changes. --- test/parallel/test-child-process-no-deprecation.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/parallel/test-child-process-no-deprecation.js b/test/parallel/test-child-process-no-deprecation.js index 20973302ddfbbb..d12e5b882f6375 100644 --- a/test/parallel/test-child-process-no-deprecation.js +++ b/test/parallel/test-child-process-no-deprecation.js @@ -9,8 +9,7 @@ if (process.argv[2] === 'child') { const spawn = require('child_process').spawn; // spawn self as child - const child = spawn(process.argv[0], [process.argv[1], 'child']); + const child = spawn(process.execPath, [process.argv[1], 'child']); - child.stderr.setEncoding('utf8'); child.stderr.on('data', common.mustNotCall()); }