test: fix test-bootstrap-modules to account for `workers` module #23876

refack · 2018-10-25T14:38:28Z

Fixed test-bootstrap-modules to pass CI when run with --experimental-worker.
(Example of current fail)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

PR-URL: nodejs#23339 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Remove style guide instruction to place punctuation inside parentehses and quotation marks. Those are not universally correct and we do not follow those rules in cases where they are not correct. PR-URL: nodejs#23346 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>

Per the Style Guide, remove the use of the personal pronoun _you_ from the formal API documentation for `domain`. PR-URL: nodejs#23347 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>

Per the Style Guide, remove the use of the personal pronoun _you_ from the formal API documentation for `worker_threads`. PR-URL: nodejs#23347 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>

Remove use of personal pronoun _you_ from formal documentation for `process`. Fix up grammar in nearby text. PR-URL: nodejs#23347 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>

Currently there are compiler warnings is emitted: ../addon.cc:17:58: warning: 'ToString' is deprecated: Use maybe version [-Wdeprecated-declarations] obj->Set(String::NewFromUtf8(isolate, "msg"), args[0]->ToString(isolate)); ^ deps/v8/include/v8.h:2537:3: note: 'ToString' has been explicitly marked deprecated here V8_DEPRECATED("Use maybe version", ^ This commit updates examples to use the non-deprecated versions. PR-URL: nodejs#23323 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

This commit extracts the common code in the existing Http2Settings constructors into a private constructor, allowing the existing ones to delegate to the private constructor it and avoid code duplication. PR-URL: nodejs#23326 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Adds a single test for a vm with an indexed property. PR-URL: nodejs#23318 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

PR-URL: nodejs#23288 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]>

ContextifyContext::CompileFunction in src/node_contextify.cc was incorrectly passing the context variable to ScriptCompiler::CompileFunctionInContext This meant that the parsingContext option in vm.compileFunction was not being applied properly to the compiled function. fixes: nodejs#23194 doc: clarify parsingContext option for vm.compileScript test: usage of parsingContext in vm.compileFunction PR-URL: nodejs#23206 Fixes: nodejs#23194 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

To help troubleshoot CI failures, add some logging. Refs: nodejs#23277 (comment) PR-URL: nodejs#23418 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: nodejs#23349 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>

PR-URL: nodejs#23337 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Update node-lint-md-cli-rollup. This silences some minor warnings that appear with `npm audit`. It also updates remark-preset-lint-node to 1.0.3 (from 1.0.2). PR-URL: nodejs#23358 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

* ATM on every ICU version bump we need to update these data. Reading it from a file makes it independant of `configre.py` changes. * Update guide. PR-URL: nodejs#23269 Refs: nodejs#23245 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

test-console-is-a-namespace.js is a WPT Console test. It is the only WPT Console test file that we have that doesn't start with `test-whatwg-`. Rename it to test-whatwg-console-is-a-namespace.js so that WPT tests can be found relatively easily. Just as it is useful to separate the WPT URL tests from our URL tests, it will likely be useful to separate our Console tests from WPT Console tests if we add more WPT Console tests (which I hope we do). PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add console-label-conversion.any.js from WPT to the test suite. PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Remove one test from test-whatwg-console-is-a-namespace that is not part of the WPT test. Put it in test-console-self-assign. PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit removes the inclusion of limits.h which was introduced in commit e812be4 ("src: make CLI options programatically accesible"), but as far as I can see it was not used there either so it look like it can safely be removed. PR-URL: nodejs#23353 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

When an instance of StreamWrap is shutting down and a "drain" event is emitted, the instance will abort as its `this[kCurrentShutdownRequest]` is already set. The following test will fail before this commit. PR-URL: nodejs#23294 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

This `_external` getter is essential for some libs to work: uWebSockets as an example. PR-URL: nodejs#21711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Improved error message description for the http server binding errors. Currently changed only in `setupListenHandle`, but needs to be change all over. Added new `uvExceptionWithHostPort` function (+export) in `lib/internal/error.js` that extracts the error message defined by libuv, using the error code, and returns an error object with the full error description. example: old error message: `listen EADDRINUSE` new error message: `listen EADDRINUSE: Address already in use` Removed exportable function `_exceptionWithHostPort` from `lib/util.js` - exported by accident Replaced `exceptionWithHostPort` to the new function `uvExceptionWithHostPort` for a more detailed error. Fixes: nodejs#22936 PR-URL: nodejs#22995 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]>

The openssl version as defined in ssl libraries is complex. The current logic to extract the major.minor.patch format uses C semantics to loop through the text and search for specific patterns. Use C++ string to tidy it up. PR-URL: nodejs#23050 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

This should be a generic type even though we are currently only using `char` as `T`. PR-URL: nodejs#23434 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>

Simplify and clarify the security-reporting text in the README. Now is also probably a good time to ping the security triage folks to make sure the text is still accurate. PR-URL: nodejs#23407 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#23574 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#23518 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

* refactor out usage of 'function' for scoping * wait till server is up to start firing requests PR-URL: nodejs#23193 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

* refactor out usage of 'function' for scoping * inline runTest function PR-URL: nodejs#23196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

These should no longer be flaky after the libuv update. Refs: nodejs#23336 PR-URL: nodejs#23356 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

addaleax · 2018-10-25T16:03:56Z

@refack … If we do it this way, I’d prefer to land it on master. We update the test file frequently, and it would get somewhat annoying to have a merge conflict every time we want a commit that touches it backported to v10.x?

jasnell

LGTM for landing in master.

fwiw, I really don't like this test.

refack · 2018-10-25T16:29:58Z

If we do it this way, I’d prefer to land it on master. We update the test file frequently, and it would get somewhat annoying to have a merge conflict every time we want a commit that touches it backported to v10.x?

I was rebasing but couldn't get a consistent result when it hit me. The + 1 side effect doesn't happen on master. The worker suite already passes.

So this PR is all we need.

richardlau · 2018-10-25T16:44:28Z

On master the magic constant is less (77) than on v10.x (78):

node/test/parallel/test-bootstrap-modules.js

Line 14 in 1523111

assert(list.length <= 77, list);

I think I remember reading somewhere that an extra module is loaded if the test is run throught the test runner as opposed to running directly on the command line.

refack · 2018-10-25T16:47:27Z

On master the magic constant is less (77) than on v10.x (78):

But it stay the same (77) whether run with --experimental-worker tools/run-worker.js or not.
It does go to 86 if run just with --experimental-worker (without the runner), but that's not how (or what) we test in the worker suite.

devsnek · 2018-10-25T16:51:17Z

what if we just removed this test... it's intention is undermined by the fact that no human can reason with its behaviour.

perhaps we can set up reports from the CI or add something informative to the test runner output?

addaleax · 2018-10-25T16:53:45Z

Yeah, I’d also be totally okay with removing that test, but I don’t think that would go through as a fast-track PR to unbreak something (we’ve discussed this in the past).

It might be a better idea to blacklist some modules that we know we don’t want to have loaded unconditionally, rather than set a fixed number.

jasnell · 2018-10-25T17:20:58Z

One key issue with test is that the number of modules loaded changes based on how the test is run, making it extremely flaky.

refack · 2018-10-25T19:14:35Z

what if we just removed this test... it's intention is undermined by the fact that no human can reason with its behaviour.

perhaps we can set up reports from the CI or add something informative to the test runner output?

IMHO the test has merit, it's not flaky it is deterministic, it just depend on how you run it. If we run it the same way, we get it's benefit.
@BridgeAR has been working hard to keep the bootstrap loaded module count low. I've also seen others who place bootstrap time in high priority.
https://github.com/nodejs/node/pull/23081/files/56c2099197e08f46d4bb4e021b40955dd8663d95#diff-b35754f7aa079e299b8ac8c51ea88959
#23050 (comment)

P.S. On Windows bootstrap time is much worse.

devsnek · 2018-10-25T19:25:56Z

@refack i'm not saying that bootstrap module count is unimportant, in fact i quite agree that it is important. i just don't think this test - in its current form - is the most helpful way to enforce the count, and just because it's deterministic doesn't mean it's easy to understand or maintain.

i suggested changing from a test to a non-fatal reporting mechanism, and anna recommended keeping a list of modules we expect to exist or not exist. personally i like anna's idea, i think keeping a big list would provide reasonable verbosity (which modules should pass) and verbosity (it would be clear which module doesn't belong thanks to @BridgeAR's array diffing)

refack · 2018-10-25T19:36:41Z

@devsnek big 👍, but that's scope creep.
This PR is just a band-aid to get the CI green again 🤷‍♂️

refack · 2018-10-25T19:44:50Z

P.S. #23884

Trott · 2018-11-02T02:22:32Z

Since this is for 10.x and that's now an LTS branch, I guess a member of @nodejs/releasers would have to land this? (Also: needs a rebase?)

refack · 2018-11-02T02:50:12Z

IIUC the underlying issue was resolved so I'm abandoning this.

styfle and others added 30 commits October 10, 2018 23:56

test: add WPT console-label-conversion test

9efe84e

Add console-label-conversion.any.js from WPT to the test suite. PR-URL: nodejs#23340 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

src: revert removal of SecureContext _external getter

f681691

This `_external` getter is essential for some libs to work: uWebSockets as an example. PR-URL: nodejs#21711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

test: fixing assertion value order

d025420

PR-URL: nodejs#23574 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: James M Snell <[email protected]>

test: fix assert.strictEqual argument order

243c227

PR-URL: nodejs#23518 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

test: improve test-gc-http-client-onerror

e402b22

* refactor out usage of 'function' for scoping * inline runTest function PR-URL: nodejs#23196 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

addaleax mentioned this pull request Oct 25, 2018

[v10.x] buffer: fix crash for invalid index types #23795

Closed

3 tasks

jasnell approved these changes Oct 25, 2018

View reviewed changes

refack mentioned this pull request Oct 25, 2018

[v10.x backport] src: initial large page (2M) support #23861

Closed

2 tasks

richardlau approved these changes Oct 25, 2018

View reviewed changes

refack mentioned this pull request Oct 25, 2018

test: make parallel/test-bootstrap-modules easier to reason about #23884

Closed

richardlau mentioned this pull request Oct 25, 2018

[v10.x backport] test: enable trace-events tests for workers #23882

Closed

3 tasks

addaleax force-pushed the v10.x-staging branch from 8b431ad to 3f63297 Compare October 27, 2018 08:14

refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 29, 2018

MylesBorins force-pushed the v10.x-staging branch from 3f63297 to 8e7a12f Compare October 30, 2018 08:43

refack closed this Nov 2, 2018

refack added abandoned and removed flaky-test Issues and PRs related to the tests with unstable failures on the CI. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 2, 2018

refack deleted the fix-bootstrap-test branch November 2, 2018 02:52

refack changed the title ~~test: fix test-bootstrap-modules for account for workers~~ test: fix test-bootstrap-modules to account for workers module Nov 4, 2018

Trott mentioned this pull request Dec 14, 2018

[10.x] deps: V8: cherry-pick 52a9e67 #25027

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix test-bootstrap-modules to account for `workers` module #23876

test: fix test-bootstrap-modules to account for `workers` module #23876

refack commented Oct 25, 2018

addaleax commented Oct 25, 2018

jasnell left a comment

refack commented Oct 25, 2018

richardlau commented Oct 25, 2018

refack commented Oct 25, 2018

devsnek commented Oct 25, 2018

addaleax commented Oct 25, 2018

jasnell commented Oct 25, 2018

refack commented Oct 25, 2018

devsnek commented Oct 25, 2018

refack commented Oct 25, 2018 •

edited

Loading

refack commented Oct 25, 2018

Trott commented Nov 2, 2018

refack commented Nov 2, 2018

test: fix test-bootstrap-modules to account for workers module #23876

test: fix test-bootstrap-modules to account for workers module #23876

Conversation

refack commented Oct 25, 2018

Checklist

addaleax commented Oct 25, 2018

jasnell left a comment

Choose a reason for hiding this comment

refack commented Oct 25, 2018

richardlau commented Oct 25, 2018

refack commented Oct 25, 2018

devsnek commented Oct 25, 2018

addaleax commented Oct 25, 2018

jasnell commented Oct 25, 2018

refack commented Oct 25, 2018

devsnek commented Oct 25, 2018

refack commented Oct 25, 2018 • edited Loading

refack commented Oct 25, 2018

Trott commented Nov 2, 2018

refack commented Nov 2, 2018

test: fix test-bootstrap-modules to account for `workers` module #23876

test: fix test-bootstrap-modules to account for `workers` module #23876

refack commented Oct 25, 2018 •

edited

Loading