Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: prefer filter to remove empty strings #23727

Merged
merged 1 commit into from
Oct 18, 2018
Merged

tools: prefer filter to remove empty strings #23727

merged 1 commit into from
Oct 18, 2018

Commits on Oct 18, 2018

  1. tools: prefer filter to remove empty strings 

    Ref: nodejs#23585 (comment)

Python's `list.remove` will throw if the element is not found and also
it removes only the first occurrence.

This patch replaces the use of `list.remove` with a `filter` which
solves both of the above mentioned problems.

PR-URL: nodejs#23727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @thefourtheye @refack
    thefourtheye authored and refack committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    1d152b6 View commit details
    Browse the repository at this point in the history