Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assert.strictEqual argument order #23518

Closed
wants to merge 1 commit into from
Closed

fix: assert.strictEqual argument order #23518

wants to merge 1 commit into from

Conversation

et4891
Copy link
Contributor

@et4891 et4891 commented Oct 12, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 12, 2018
@jasnell jasnell added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
@targos targos removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
@trivikr
Copy link
Member

trivikr commented Oct 12, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17754/

@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 12, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17758/

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 12, 2018
@addaleax
Copy link
Member

Your author name in this commit is given as “et4891”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

@Trott
Copy link
Member

Trott commented Oct 12, 2018

CI is green. Collaborators, please 👍 here to fast-track.

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 12, 2018
@et4891 @Trott
test: fix assert.strictEqual argument order
b4e979f 
PR-URL: nodejs#23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 12, 2018

Landed in b4e979f

@Trott Trott closed this Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 12, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

Trott pushed a commit that referenced this pull request Oct 13, 2018
@et4891 @Trott
test: fix assert.strictEqual argument order
4089a55 
PR-URL: #23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Oct 13, 2018
@et4891 @targos
test: fix assert.strictEqual argument order
243c227 
PR-URL: #23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@et4891 @jasnell
test: fix assert.strictEqual argument order
bd88c98 
PR-URL: #23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@et4891 @MylesBorins
test: fix assert.strictEqual argument order
6fa033c 
PR-URL: #23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@et4891 @rvagg
test: fix assert.strictEqual argument order
bf06d05 
PR-URL: #23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@et4891 @MylesBorins
test: fix assert.strictEqual argument order
b2e173b 
PR-URL: #23518
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@jasnell jasnell jasnell approved these changes

@digitalinfinity digitalinfinity digitalinfinity approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@et4891 @trivikr @Trott @addaleax @digitalinfinity @jasnell @gireeshpunathil @targos @nodejs-github-bot