doc: remove outdated notes on stdio in workers #23054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workers support `stdio` streams since the initial PR landed. These lines are editing leftovers from before that and should be removed.
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/994/pipeline Edit: 👍 this comment to approve fast-tracking. |
nodejs-github-bot
added
doc
addaleax
added
worker
tniessen
approved these changes
Sep 24, 2018
cjihrig
approved these changes
Sep 24, 2018
vsemozhetbyt
approved these changes
Sep 24, 2018
vsemozhetbyt
added
the
author ready
lpinca
approved these changes
Sep 24, 2018
|
Landed in a5b92a7 |
addaleax
added a commit
that referenced
this pull request
Sep 24, 2018
Workers support `stdio` streams since the initial PR landed. These lines are editing leftovers from before that and should be removed. PR-URL: #23054 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 24, 2018
Workers support `stdio` streams since the initial PR landed. These lines are editing leftovers from before that and should be removed. PR-URL: #23054 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workers support
stdiostreams since the initial PR landed. Theselines are editing leftovers from before that and should be removed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes