test: test undefined for util #22741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe these cases are already accounted for when no arguments are passed. |
|
@mscdex given that some of these methods are backed by natives it seems reasonable to test no-args undefined vs explicit undefined. |
devsnek
approved these changes
Sep 7, 2018
trivikr
approved these changes
Sep 7, 2018
lpinca
approved these changes
Sep 7, 2018
jasnell
approved these changes
Sep 7, 2018
BridgeAR
approved these changes
Sep 7, 2018
|
Last CI run was not successful for unrelated reasons (nodejs/build#1495). |
|
Logically speaking, it shouldn’t be failed. What’s the real reason making CI failed ? |
|
@ZYSzys the rebuild I started is good (only one flaky test making it yellow, but yellow means it can be ignored). |
thefourtheye
approved these changes
Sep 27, 2018
|
CI is green Landed in a00eee3 |
mhdawson
pushed a commit
that referenced
this pull request
Sep 27, 2018
PR-URL: #22741 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
PR-URL: #22741 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
PR-URL: #22741 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some
undefinedtests for util.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes