test: replaces assert.throws() with common.expectsError() #22689
Conversation
replaces assert.throws() with common.expectsError() to check error code and error type in parallel/test-buffer-alloc.js
@BridgeAR The reason to use Once 10.x is the oldest supported version, we can likely get rid of |
BridgeAR
added
the
author ready
| assert.throws(() => b.write('', 2048), RangeError); | ||
| common.expectsError( | ||
| () => b.write('', 2048), | ||
| { |
There was a problem hiding this comment.
nit: Since this error object is used multiple times in the test, it can be stored in a const.
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/17084/ |
I remember we used to use |
|
@refack |
replaces assert.throws() with common.expectsError() to check error code and error type in parallel/test-buffer-alloc.js PR-URL: nodejs#22689 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 9782ce2. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
replaces assert.throws() with common.expectsError() to check error code and error type in parallel/test-buffer-alloc.js PR-URL: #22689 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
replaces assert.throws() with common.expectsError() to check error code
and error type in parallel/test-buffer-alloc.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes