Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: make pipe_wrap binding internal #22482

Merged
merged 1 commit into from
Aug 29, 2018
Merged

lib: make pipe_wrap binding internal #22482

merged 1 commit into from
Aug 29, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 23, 2018

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/646/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 23, 2018
@jasnell jasnell mentioned this pull request Aug 23, 2018
Closed
33 tasks
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 23, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 27, 2018

This needs to be rebased and a CI run, but first it needs reviews from @nodejs/tsc.

@BridgeAR
Copy link
Member

This needs a rebase.

@cjihrig
lib: make pipe_wrap binding internal
6a689c8 
PR-URL: nodejs#22482
Refs: nodejs#22160
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 29, 2018

Green CI: https://ci.nodejs.org/job/node-test-pull-request/16861/

@cjihrig cjihrig merged commit 6a689c8 into nodejs:master Aug 29, 2018
@cjihrig cjihrig deleted the pipe-wrap branch August 29, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @BridgeAR @jasnell @lpinca @targos