src: remove calls to deprecated v8 functions (NumberValue) #22094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all calls to deprecated v8 functions (here: Value::NumberValue) inside the code (src directory only).
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Aug 2, 2018
src/async_wrap.cc
Outdated
| args[0]->IsNumber() | ||
| ? args[0] | ||
| ->NumberValue(args.GetIsolate()->GetCurrentContext()) | ||
| .ToChecked() |
There was a problem hiding this comment.
… args[0].As<Number>()->Value() …?
src/async_wrap.cc
Outdated
| wrap->AsyncReset(execution_async_id); | ||
| } | ||
|
|
||
|
|
||
| void AsyncWrap::QueueDestroyAsyncId(const FunctionCallbackInfo<Value>& args) { | ||
| CHECK(args[0]->IsNumber()); | ||
| AsyncWrap::EmitDestroy( | ||
| Environment::GetCurrent(args), args[0]->NumberValue()); | ||
| Environment::GetCurrent(args), | ||
| args[0]->NumberValue(args.GetIsolate()->GetCurrentContext()).ToChecked()); |
There was a problem hiding this comment.
We skip validation of the argument in JS land when async hooks checks are disabled – so we probably don’t want ToChecked()?
There was a problem hiding this comment.
Umm, dunno. There's literally a CHECK above, so I thought ToChecked would work here. I mean, it might still crash, sure, but nowhere it didn't crash earlier.
There was a problem hiding this comment.
Oh, right, I missed that – in that case, we don’t need NumberValue() either and can cast via .As<Number>(), right?
There was a problem hiding this comment.
:P You're right. Updating the PR.
jasnell
approved these changes
Aug 3, 2018
cjihrig
approved these changes
Aug 7, 2018
addaleax
approved these changes
Aug 7, 2018
targos
approved these changes
Aug 7, 2018
|
Landing this. |
|
Landed in c6a54af |
ryzokuken
added a commit
that referenced
this pull request
Aug 7, 2018
Remove all calls to deprecated v8 functions (here: Value::NumberValue) inside the code (src directory only). PR-URL: #22094 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 11, 2018
Remove all calls to deprecated v8 functions (here: Value::NumberValue) inside the code (src directory only). PR-URL: #22094 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all calls to deprecated v8 functions (here:
Value::NumberValue) inside the code (src directory only).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @addaleax @hashseed