Update BUILDING.md #22067
Closed
Update BUILDING.md #22067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grammatical error corrected.
nodejs-github-bot
added
build
addaleax
approved these changes
Aug 1, 2018
|
Collaborators, please feel free to 👍 this comment to approve fast-tracking. |
|
Good day, may I know when will it be merged? |
|
@brandonlwt Fast-tracking means that it can be merged as soon as all automated checks are green. … Which they are now, so: Landed in 05b3176 🎉 Congratulations and thanks for the pull request! |
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2018
Grammatical error corrected. PR-URL: #22067 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
|
Oh! Thank you for the explanation! Highly appreciated! |
targos
pushed a commit
that referenced
this pull request
Aug 1, 2018
Grammatical error corrected. PR-URL: #22067 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammatical error corrected.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes