Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up PackageConfig pseudo-boolean fields #21987

Closed
wants to merge 1 commit into from
Closed

src: clean up PackageConfig pseudo-boolean fields #21987

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/360/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 26, 2018
@addaleax
Copy link
Member Author

addaleax commented Aug 1, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/16120

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 1, 2018
@targos
Copy link
Member

targos commented Aug 4, 2018

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16191/

@devsnek
Copy link
Member

devsnek commented Aug 4, 2018

why are these enums at all

@addaleax
Copy link
Member Author

addaleax commented Aug 5, 2018

@devsnek Some C++ programmers (including me) feel that using 2-valued enums over boolean can be valuable due to the improved type safety.

@addaleax
Copy link
Member Author

addaleax commented Aug 5, 2018

Landed in a196aa2

@addaleax addaleax closed this Aug 5, 2018
@addaleax addaleax deleted the package-loader-bools branch August 5, 2018 00:15
addaleax added a commit that referenced this pull request Aug 5, 2018
@addaleax
src: clean up PackageConfig pseudo-boolean fields
a196aa2 
PR-URL: #21987
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Aug 6, 2018
@addaleax @targos
src: clean up PackageConfig pseudo-boolean fields
0ca831a 
PR-URL: #21987
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @targos @devsnek @jasnell @TimothyGu @cjihrig @BridgeAR