From 959d3421ba43fdf7bf868c9ddeff226fa0e69525 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Mon, 23 Jul 2018 19:10:28 +0300 Subject: [PATCH 1/3] doc: add missing worker error ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER was missing from the docs - add it there based on the wording Anna used in the her PR. PR-URL: Reviewed-By: --- doc/api/errors.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/api/errors.md b/doc/api/errors.md index 3e94ce8e3bf709..8f19235e8f8bb4 100644 --- a/doc/api/errors.md +++ b/doc/api/errors.md @@ -1669,6 +1669,13 @@ category. The `trace_events` module could not be loaded because Node.js was compiled with the `--without-v8-platform` flag. + +### ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER + +A SharedArrayBuffer object was transfered but we do not see a lifetime partner +object and it was not us who externalized it - we are not sure how to serialize +it because it's unclear how the memory is actually owned. + ### ERR_TRANSFORM_ALREADY_TRANSFORMING From c82fc76ce80b87372d0bc592e3b0335f80020da2 Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Mon, 23 Jul 2018 19:44:00 +0300 Subject: [PATCH 2/3] fixup! better phrasing for the comment. --- doc/api/errors.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/api/errors.md b/doc/api/errors.md index 8f19235e8f8bb4..bff5ff0a3fd0dd 100644 --- a/doc/api/errors.md +++ b/doc/api/errors.md @@ -1672,9 +1672,11 @@ the `--without-v8-platform` flag. ### ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER -A SharedArrayBuffer object was transfered but we do not see a lifetime partner -object and it was not us who externalized it - we are not sure how to serialize -it because it's unclear how the memory is actually owned. +A `SharedArrayBuffer` whose memory is not managed by the JavaScript engine or by Node.js was +encountered during serialization. Such a `SharedArrayBuffer` can not be serialized. + +This can only happen when native addons create `SharedArrayBuffer`s in "externalized" mode, or put +existing `SharedArrayBuffer` into externalized mode. ### ERR_TRANSFORM_ALREADY_TRANSFORMING From 8a5ff77567d1b7289e894daae1c2a3e6fedbf05f Mon Sep 17 00:00:00 2001 From: Benjamin Gruenbaum Date: Mon, 23 Jul 2018 20:16:49 +0300 Subject: [PATCH 3/3] fixup! style nits --- doc/api/errors.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/api/errors.md b/doc/api/errors.md index bff5ff0a3fd0dd..af24fc2cb12225 100644 --- a/doc/api/errors.md +++ b/doc/api/errors.md @@ -1672,11 +1672,12 @@ the `--without-v8-platform` flag. ### ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER -A `SharedArrayBuffer` whose memory is not managed by the JavaScript engine or by Node.js was -encountered during serialization. Such a `SharedArrayBuffer` can not be serialized. +A `SharedArrayBuffer` whose memory is not managed by the JavaScript engine +or by Node.js was encountered during serialization. Such a `SharedArrayBuffer` +cannot be serialized. -This can only happen when native addons create `SharedArrayBuffer`s in "externalized" mode, or put -existing `SharedArrayBuffer` into externalized mode. +This can only happen when native addons create `SharedArrayBuffer`s in +"externalized" mode, or put existing `SharedArrayBuffer` into externalized mode. ### ERR_TRANSFORM_ALREADY_TRANSFORMING