Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add missing cmath include to traced_value.cc #21924

Closed
wants to merge 1 commit into from
Closed

src: add missing cmath include to traced_value.cc #21924

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fixes: #21903

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/328/pipeline

maclover7
maclover7 approved these changes Jul 22, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a test we could add here to make sure this doesn't break? Or maybe there was a warning that was missed in CI somewhere?

@maclover7 maclover7 added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 22, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15975/

@maclover7 I don't know. My guess that this went undetected because cmath was included as a transitive dependency on most systems, which makes this very hard to detect.

@addaleax
Copy link
Member Author

CI failures are both known flakes, and it’s not like this change would have interacted with them in some way, but:

OS X re-build: https://ci.nodejs.org/job/node-test-commit-osx/19964/
Windows re-build: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19430

@addaleax
Copy link
Member Author

Landed in 2db74f2

@addaleax addaleax closed this Jul 26, 2018
@addaleax addaleax deleted the include-cmath branch July 26, 2018 11:09
addaleax added a commit that referenced this pull request Jul 26, 2018
@addaleax
src: add missing cmath include to traced_value.cc
2db74f2 
Fixes: #21903

PR-URL: #21924
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
targos pushed a commit that referenced this pull request Jul 26, 2018
@addaleax @targos
src: add missing cmath include to traced_value.cc
f6606bf 
Fixes: #21903

PR-URL: #21924
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node 10.7.0 fails to build - error in traced_value.cc
8 participants
@addaleax @nodejs-github-bot @ChALkeR @jasnell @targos @cjihrig @maclover7 @JungMinu