Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make getnodeversion.py python3-compatible #21872

Closed
wants to merge 1 commit into from
Closed

tools: make getnodeversion.py python3-compatible #21872

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

When the system's python is Python 3, this script which is used during make lint failed with a syntax error. This adds print braces so it is compatible with both Python 2 and 3.

@nodejs-github-bot
Copy link
Collaborator

@silverwind build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/307/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 18, 2018
@silverwind silverwind added tools Issues and PRs related to the tools directory. and removed build Issues and PRs related to build files or the CI. labels Jul 18, 2018
@Trott Trott added the python PRs and issues that require attention from people who are familiar with Python. label Jul 18, 2018
@silverwind
Copy link
Contributor Author

Thanks, landed in 287521d.

@silverwind silverwind closed this Jul 19, 2018
@silverwind silverwind deleted the python3-getnodeversion branch July 19, 2018 17:19
silverwind added a commit that referenced this pull request Jul 19, 2018
@silverwind
tools: make getnodeversion.py python3-compatible
287521d 
PR-URL: #21872
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2018
@silverwind @targos
tools: make getnodeversion.py python3-compatible
6b925eb 
PR-URL: #21872
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020
@silverwind @BaochengSu
tools: make getnodeversion.py python3-compatible
aeee583 
PR-URL: nodejs#21872
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
(cherry picked from commit 287521d)
This was referenced Jun 18, 2021
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @nodejs-github-bot @jasnell @Trott @addaleax @cjihrig @trivikr