Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explicitly mention sync APIs with doc links of the related async… #21479

Closed
wants to merge 1 commit into from
Closed

doc: explicitly mention sync APIs with doc links of the related async… #21479

wants to merge 1 commit into from

Conversation

BeniCheni
Copy link
Contributor

Per suggestion from issue #21197, explicitly mention the fs.*Sync APIs with doc links of the related async APIs, if applicable.

P.S.: Used best judgment to use the anchors to support doc links markdown, based on some testings of the fs.md in my forked branch. Happy to update further per code review comments. Thanks in advance for your review(s),

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: #21197

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jun 23, 2018
@BeniCheni
Copy link
Contributor Author

Missed #21243. Closing this duplicated PR.

@BeniCheni BeniCheni closed this Jun 23, 2018
@BeniCheni BeniCheni deleted the sync-fs-doc branch August 24, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants