Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add override to ThreadPool methods in zlib #20769

Closed
wants to merge 2 commits into from
Closed

src: add override to ThreadPool methods in zlib #20769

wants to merge 2 commits into from

Commits on May 16, 2018

  1. src: add override to ThreadPool methods in zlib 

    Currently the following compiler warnings are generated:
../src/node_zlib.cc:222:8:
warning: 'DoThreadPoolWork' overrides a member function but is not marked
      'override' [-Winconsistent-missing-override]
  void DoThreadPoolWork() {
       ^
../src/node_internals.h:509:16: note: overridden virtual function is here
  virtual void DoThreadPoolWork() = 0;
               ^
../src/node_zlib.cc:357:8: warning:
'AfterThreadPoolWork' overrides a member function but is not marked
      'override' [-Winconsistent-missing-override]
  void AfterThreadPoolWork(int status) {
       ^
../src/node_internals.h:510:16:
note: overridden virtual function is here
  virtual void AfterThreadPoolWork(int status) = 0;
               ^

This commit adds the override specifier to the methods to silence the
warnings.
    @danbev
    danbev committed May 16, 2018
    Configuration menu
    Copy the full SHA
    98b4faa View commit details
    Browse the repository at this point in the history

  2. squash: remove extra white line

    @danbev
    danbev committed May 16, 2018
    Configuration menu
    Copy the full SHA
    f665e8b View commit details
    Browse the repository at this point in the history