doc: fix typo in COLLABORATOR_GUIDE.md #20742
Conversation
|
cc @nodejs/linting How can we fix the linting issue in this case? |
|
@vsemozhetbyt good question... I guess it would actually be best to rename the group instead. Ping @nodejs/tsc |
|
{digression} IMHO, this doesn't need review from the TSC or even a ping to the list of all collaborators – this is an uncontroversial typo fix. Global pings should be avoided unless necessary. {/digression} |
|
How about we change the capitalization on the group name instead (and in the CODEOWNERS file too)? Then the linter will be happy and we'll have a group name that correctly styles the name |
|
(@ofrobots I think the ping may have been automated by the CODEOWNERS file. It's possible we don't need a TSC ping for changes to COLLABORATOR_GUIDE. Basically only if it entails a governance change. Maybe that line can be removed from CODEOWNERS.) |
|
I'd prefer we change the name of the team to use |
|
@ofrobots It seems the ping was not about typo itself: we have a conflict between linting rule requiring |
|
@vsemozhetbyt Are you 👍if I change the team name to use |
|
@Trott Yes, please, this seems more consistent. |
|
It appears that GitHub has started (or maybe always has?) lowercasing team names in @-mentions regardless of how you actually name the team. I'll see about updating the prohibited-strings code to ignore prohibited strings that appear inside of @-strings so this starts passing. |
|
Published a new version of I put the update as the first commit on this PR with the original changes as the second commit. (I recommend leaving them separate for what I hope are obvious reasons.) Full CI (because now we're updating tools): https://ci.nodejs.org/job/node-test-pull-request/14895/ @vsemozhetbyt Thanks for your patience with this! |
|
Hmmm...looks like I need to remove some OS-dependent stuff: 17:41:03 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
17:41:03 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"freebsd","arch":"x64"}) |
Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string.
|
Re-running arm-fanned, addons failure is clearly spurious: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1230/ |
|
Got better results this time, but still some spurious ones in arm-fanned. Trying that one again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1231/ |
|
I'm wondering if all my terminating of Pi jobs in process is what's causing the problem for arm-fanned. Going to let the last one finish this time. Again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1232/ |
|
(Other than arm-fanned, CI is totally green.) |
|
arm-fanned is green too now. Landing... |
|
Oops, not landing because it hasn't been approved for fast-tracking. |
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
|
the first commit only modifies two package-lock.json files? |
|
@Trott is there not also a package.json to update? |
It's not necessary, but there could be one. That would require publishing a new version of |
|
@Trott if it isn't needed its fine, i was just confused when i saw lock files changed without the actual package changing is all |
|
@Trott Are we good to land? |
BridgeAR
added
the
author ready
Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string. PR-URL: nodejs#20742 Refs: nodejs#20740 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#20742 Refs: nodejs#20740 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
@vsemozhetbyt A belated "yes". :-D |
Update to remark-lint-prohibited-strings 1.0.3 to avoid false positives with GitHub team names which must be lowercased no matter what our prohibited-strings rules say about a particular string. PR-URL: #20742 Refs: #20740 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #20742 Refs: #20740 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesRefs: #20740