Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update VM section text #20595

Closed
wants to merge 1 commit into from
Closed

doc: update VM section text #20595

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 8, 2018

This commit updates the VM section with suggestion for a minor
improvement (hopefully) of the text.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@danbev
doc: update VM section text
31c7061 
This commit updates the VM section with suggestion for a minor
improvement (hopefully) of the text.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels May 8, 2018
@danbev
Copy link
Contributor Author

danbev commented May 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14716/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 8, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@danbev
Copy link
Contributor Author

danbev commented May 9, 2018

Landed in 5c9572d.

@danbev danbev closed this May 9, 2018
@danbev danbev deleted the vm_doc_minor_suggestions branch May 9, 2018 08:24
danbev added a commit to danbev/node that referenced this pull request May 9, 2018
@danbev
doc: update VM section text
5c9572d 
This commit updates the VM section with suggestion for a minor
improvement (hopefully) of the text.

PR-URL: nodejs#20595
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request May 12, 2018
@danbev @targos
doc: update VM section text
9177f73 
This commit updates the VM section with suggestion for a minor
improvement (hopefully) of the text.

PR-URL: #20595
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@devsnek devsnek devsnek approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @vsemozhetbyt @jasnell @Trott @lpinca @devsnek @nodejs-github-bot