Commits on May 19, 2018

1. fs: drop duplicate API in promises mode …

   This drops exporting duplicate methods that accept FileHandle as the
   first argument (to mirror callback-based methods accepting 'fd').
   
   Those methods were not adding actual value to the API because all of
   those are already present as FileHandle methods, and they would
   probably be confusing to the new users and making docs harder to read.
   
   Also, the API was a bit inconsistent and lacked .close(handle).
   
   Fixes: nodejs#20548
   PR-URL: nodejs#20559
   Reviewed-By: Matteo Collina <[email protected]>
   Reviewed-By: Franziska Hinkelmann <[email protected]>
   Reviewed-By: James M Snell <[email protected]>
   Reviewed-By: Benjamin Gruenbaum <[email protected]>
   Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
   Reviewed-By: Colin Ihrig <[email protected]>
   Reviewed-By: Joyee Cheung <[email protected]>
   Reviewed-By: Ruben Bridgewater <[email protected]>

   

   ChALkeR committed May 19, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for c594d15
   • Browse repository at this point

   Copy the full SHA

   c594d15 View commit details

   Browse the repository at this point in the history