test: fix assertion in test-console #20557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the assertion after the second call to `console.time()` to actually make sure that the time is not reset. Refs: nodejs#20442
cjihrig
approved these changes
May 6, 2018
jasnell
approved these changes
May 6, 2018
lpinca
added
the
author ready
trivikr
approved these changes
May 14, 2018
|
node-test-commit-windows-fanned CI rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/17953/ |
|
Landed in 60ef7d1 |
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
Move the assertion after the second call to `console.time()` to actually make sure that the time is not reset. Refs: #20442 PR-URL: #20557 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Adding dont-land-on labels because this depends on a semver-major PR, let me know if that’s wrong |
targos
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the assertion after the second call to
console.time()toactually make sure that the time is not reset.
Refs: #20442
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes