Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add alpine check #20229

Closed
wants to merge 4 commits into from
Closed

test: add alpine check #20229

wants to merge 4 commits into from

Conversation

BridgeAR
Copy link
Member

Potential alternative to #20228

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 23, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Apr 23, 2018 •
edited
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/14448/
CI https://ci.nodejs.org/job/node-test-pull-request/14457/

@BridgeAR
Copy link
Member Author

This currently has a false positive for fedora. Does anyone know what could be added to distinguish fedora and alpine?

@devsnek
Copy link
Member

devsnek commented Apr 23, 2018

lsb_release or check for /etc/alpine-release maybe? I don't know much about alpine

@BridgeAR
Copy link
Member Author

Closing for now. The original PR got reverted.

@BridgeAR BridgeAR closed this Apr 24, 2018
@BridgeAR BridgeAR mentioned this pull request Apr 24, 2018
Merged
@BridgeAR BridgeAR deleted the add-alpine-check branch January 20, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BridgeAR @devsnek @nodejs-github-bot