inspector: migrate node to js_protocol.pdl #20141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
devsnek
approved these changes
Apr 19, 2018
bnoordhuis
approved these changes
Apr 19, 2018
There was a problem hiding this comment.
Thanks, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/14380/
The .pdl file (pronounced "poodle"?) is a lot more readable too.
joyeecheung
approved these changes
Apr 19, 2018
jasnell
approved these changes
Apr 19, 2018
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json.
|
Unfortunately we do not have dedicated doc about .pdl but we believe that it is self explained and some basic format parser may be found in our ConverProtocolToJSON.py script. I think that we will add some doc later. @pavelfeldman , is poodle right pronunciation? :) To fix CI I introduced temporary action which copies .pdl file to shared_intermediate_folder, this action will gone after one of the next V8 roll. |
|
Ok, would definitely prefer to have documentation for the format sooner than later :-) |
alexkozy
added a commit
that referenced
this pull request
Apr 20, 2018
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json. PR-URL: #20141 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in fda2b9a |
|
The passing CI didn't get posted: https://ci.nodejs.org/job/node-test-pull-request/14388/ |
|
Thanks for posting a link! |
jasnell
pushed a commit
that referenced
this pull request
Apr 20, 2018
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json. PR-URL: #20141 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
hashseed
pushed a commit
to v8/node
that referenced
this pull request
Apr 23, 2018
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json. PR-URL: nodejs#20141 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json. PR-URL: nodejs#20141 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On inspector side we are going to deprecate .json protocol
definition format and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes