Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove CII badge in README #18908

Closed
wants to merge 1 commit into from
Closed

doc: remove CII badge in README #18908

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

I agree with @Trott in #18884 (review), this badge servers a questionable purpose and I think we can safely remove it.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 21, 2018
@gibfahn
Copy link
Member

gibfahn commented Feb 21, 2018

I think @rvagg was involved in its addition, so cc/ them.

@silverwind
Copy link
Contributor Author

It was added on fea3ba4.

@gibfahn
Copy link
Member

gibfahn commented Feb 21, 2018

Previous discussion in #11327 #13231 #13283

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 22, 2018
@BridgeAR
Copy link
Member

Marking as ready without running a CI as there was only code removed and it is therefore obsolete.

@silverwind
Copy link
Contributor Author

Thanks, landed in b544430.

@silverwind silverwind closed this Feb 22, 2018
@silverwind silverwind deleted the no-batches branch February 22, 2018 05:40
silverwind added a commit that referenced this pull request Feb 22, 2018
@silverwind
doc: remove CII badge in README
b544430 
PR-URL: #18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
@silverwind @addaleax
doc: remove CII badge in README
15c9a71 
PR-URL: nodejs#18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@silverwind @addaleax
doc: remove CII badge in README
205a84c 
PR-URL: #18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax addaleax mentioned this pull request Feb 27, 2018
Closed
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@silverwind @MayaLekova
doc: remove CII badge in README
a3a5737 
PR-URL: nodejs#18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@silverwind @MylesBorins
doc: remove CII badge in README
b37c2c5 
PR-URL: #18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@silverwind @MylesBorins
doc: remove CII badge in README
faf9a8b 
PR-URL: #18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@silverwind @MylesBorins
doc: remove CII badge in README
3aeb98a 
PR-URL: #18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@silverwind @MylesBorins
doc: remove CII badge in README
07e2bd4 
PR-URL: #18908
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@mscdex mscdex mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@Trott Trott Trott approved these changes

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.