Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test-tls-pause #18714

Closed
wants to merge 3 commits into from
Closed

Refactor test-tls-pause #18714

wants to merge 3 commits into from

Conversation

juggernaut451
Copy link
Contributor

@juggernaut451 juggernaut451 commented Feb 11, 2018 •
edited
Loading

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Changes that are done in file are :

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2018
starkwang
starkwang approved these changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@starkwang starkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott reviewed Feb 14, 2018
View reviewed changes
test/parallel/test-tls-pause.js Outdated
@@ -24,6 +24,9 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

// This test ensures that the data received over tls-server after pause
// is same as what it was send
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: send -> sent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott Thanks for feedback!

richardlau
richardlau reviewed Feb 14, 2018
View reviewed changes
test/parallel/test-tls-pause.js Outdated

server.listen(0, function() {
server.listen(0, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback to listen could (should?) also be wrapped in common.mustCall.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@jasnell
Copy link
Member

jasnell commented Feb 16, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13206/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 17, 2018 •
edited
Loading

CI https://ci.nodejs.org/job/node-test-pull-request/13241/

@BridgeAR
Copy link
Member

Landed in c9b42c4 🎉

@BridgeAR BridgeAR closed this Feb 17, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 17, 2018
@juggernaut451 @BridgeAR
test: refactor parallel/test-tls-pause
c9b42c4 
Use arrow functions and common.mustCall() and add a description.

PR-URL: nodejs#18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
e7a415d 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
72484e5 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
d73f214 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@juggernaut451 @MayaLekova
test: refactor parallel/test-tls-pause
b909318 
Use arrow functions and common.mustCall() and add a description.

PR-URL: nodejs#18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
e5130db 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
b197422 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
ecd8659 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@juggernaut451 @MylesBorins
test: refactor parallel/test-tls-pause
ffa7b50 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@starkwang starkwang starkwang approved these changes

@richardlau richardlau richardlau approved these changes

@hiroppy hiroppy hiroppy approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@daynin daynin daynin approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.