Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: use Date.now() and move test to parallel #18563

Closed
wants to merge 3 commits into from
Closed

readline: use Date.now() and move test to parallel #18563

wants to merge 3 commits into from

Commits on Feb 4, 2018

  1. readline: use Date.now() and move test to parallel 

    The readline module wants a truthy time while using Timer.now() doesn't
necessarily guarantee that early on in the process' life. It also
doesn't actually resolve the timing issues experienced in an earlier
issue. Instead, this PR fixes the related tests and moves them back
to parallel.

Refs: nodejs#14674
    @apapirovski
    apapirovski committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    eda075e View commit details
    Browse the repository at this point in the history

  2. fixup: don't early assign the value

    @apapirovski
    apapirovski committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    81ce2d1 View commit details
    Browse the repository at this point in the history

  3. fixup: crlfDelay to Infinity

    @apapirovski
    apapirovski committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    85ec7bc View commit details
    Browse the repository at this point in the history