Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x backport] PRs: 17403, 17456 and 17588 #18487

Closed
wants to merge 3 commits into from
Closed

[v9.x backport] PRs: 17403, 17456 and 17588 #18487

wants to merge 3 commits into from

Commits on Jan 31, 2018

  1. events: move domain handling from events to domain 

    PR-URL: nodejs#17403
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
    @vdeturckheim @apapirovski
    vdeturckheim authored and apapirovski committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    4f5ac7f View commit details
    Browse the repository at this point in the history

  2. events: use Reflect.apply 

    Instead of callback bound apply, instead use the standard
Reflect.apply. This is both safer and appears to offer
a slight performance benefit.

PR-URL: nodejs#17456
Refs: nodejs#12956
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
    @apapirovski
    apapirovski committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    a3417fe View commit details
    Browse the repository at this point in the history

  3. domain: fix error emit handling 

    Fix an issue where error is never emitted on the original EventEmitter
in situations where a listener for error does exist.

Refactor to eliminate unnecessary try/catch/finally block.

PR-URL: nodejs#17588
Refs: nodejs#17403
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @apapirovski
    apapirovski committed Jan 31, 2018
    Configuration menu
    Copy the full SHA
    9b98742 View commit details
    Browse the repository at this point in the history