Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.x backport] test: fix require-deps-deprecation for installed deps #18077

Closed
wants to merge 2 commits into from

Commits on Jan 10, 2018

  1. test: fix require-deps-deprecation for installed deps

    Test test-require-deps-deprecation.js was failing when user already had
    node installed with acorn in require.resolve range.
    
    Modified test to acknowledge the possibility and throw only if acorn is
    found in the deps directory.
    
    Also changed the deprecation test for v9.x: common.expectWarning was failing
    because the required deps now throw ReferenceErrors when not properly called
    internally in the right order.
    
    PR-URL: nodejs#17848
    Fixes: nodejs#17148
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Tiriel committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    c341f93 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2018

  1. test: removed deprecation tests

    Tiriel committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    e93767f View commit details
    Browse the repository at this point in the history