src: update make for new code coverage locations #17987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files for code coverage are moving to the build repository. Update the references to reflect this.
nodejs-github-bot
added
the
build
TimothyGu
approved these changes
Jan 5, 2018
gireeshpunathil
approved these changes
Jan 5, 2018
XadillaX
approved these changes
Jan 5, 2018
lpinca
approved these changes
Jan 5, 2018
cjihrig
approved these changes
Jan 5, 2018
jasnell
approved these changes
Jan 5, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/12433/ |
|
CI failure was an infra issue so its ok and Code coverage run was good, landing. |
|
Landed as c91bd2f |
mhdawson
added a commit
that referenced
this pull request
Jan 8, 2018
The files for code coverage are moving to the build repository. Update the references to reflect this. PR-URL: #17987 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2018
The files for code coverage are moving to the build repository. Update the references to reflect this. PR-URL: #17987 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 10, 2018
The files for code coverage are moving to the build repository. Update the references to reflect this. PR-URL: #17987 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Jan 10, 2018
In nodejs#17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these.
2 tasks
mhdawson
added a commit
that referenced
this pull request
Jan 16, 2018
In #17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: #18081 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Should this land on lts? This lands cleanly on 8.x but will need a backport for 6.x |
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
In #17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: #18081 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
ping re: backport edit: should come with #18081 |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
The files for code coverage are moving to the build repository. Update the references to reflect this. PR-URL: #17987 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
In #17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: #18081 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
The files for code coverage are moving to the build repository. Update the references to reflect this. PR-URL: #17987 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
In #17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: #18081 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
The files for code coverage are moving to the build repository. Update the references to reflect this. PR-URL: #17987 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
In #17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: #18081 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files for code coverage are moving to the build
repository. Update the references to reflect this.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test