test: reduce scope of variable in common module #17830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrayBufferViews is used by only one function so scope it to that function (in the common module).
vsemozhetbyt
approved these changes
Dec 22, 2017
maclover7
approved these changes
Dec 23, 2017
TimothyGu
approved these changes
Dec 23, 2017
lpinca
approved these changes
Dec 23, 2017
maclover7
added
the
author ready
|
Landed in 03b8ac1 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 26, 2017
arrayBufferViews is used by only one function so scope it to that function (in the common module). PR-URL: nodejs#17830 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
arrayBufferViews is used by only one function so scope it to that function (in the common module). PR-URL: #17830 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
arrayBufferViews is used by only one function so scope it to that function (in the common module). PR-URL: #17830 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
arrayBufferViews is used by only one function so scope it to that function (in the common module). PR-URL: #17830 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
arrayBufferViews is used by only one function so scope it to that function (in the common module). PR-URL: #17830 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
arrayBufferViews is used by only one function so scope it to that function (in the common module). PR-URL: #17830 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arrayBufferViews is used by only one function so scope it to that
function (in the common module).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test