Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: move eslint and install babel-eslint #17820

Merged
merged 4 commits into from
Jan 11, 2018
Merged

tools: move eslint and install babel-eslint #17820

merged 4 commits into from
Jan 11, 2018

Commits on Jan 11, 2018

  1. tools: move eslint from tools to tools/node_modules 

    This is required because we need to add the babel-eslint dependency
and it has to be able to resolve "eslint".
babel-eslint is required to support future ES features such as async
iterators and import.meta.

Refs: nodejs#17755
PR-URL: nodejs#17820
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
    @targos
    targos committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    3dc3063 View commit details
    Browse the repository at this point in the history

  2. tools: update ESLint to 4.15.0 

    PR-URL: nodejs#17820
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
    @targos
    targos committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    7a52c51 View commit details
    Browse the repository at this point in the history

  3. tools: add babel-eslint 

    Create tools/update-babel-eslint.sh script and execute it to do the
first installation of the package.
Update tools/license-builder.sh and execute it to add babel-eslint's
license to our LICENSE file.

PR-URL: nodejs#17820
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
    @targos
    targos committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    b043a70 View commit details
    Browse the repository at this point in the history

  4. tools: use babel-eslint as ESLint parser 

    PR-URL: nodejs#17820
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
    @targos
    targos committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    4d96c17 View commit details
    Browse the repository at this point in the history