Revert: repl: support top-level await #17807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
4 tasks
|
I'm +1 on this but I would also be plus one on keeping the new functionality as experimental and keeping it behind a flag while the issues are worked through. Top level await is quite popular and users want it. |
|
Yes, I'm definitely in favor of having top level await. I put this together to give us one option. |
|
Commit logs need more context. I, for one, have no idea why it's being reverted. |
TimothyGu
suggested changes
Dec 21, 2017
There was a problem hiding this comment.
-1 from me because of #15566 (comment). I’d rather see it being hidden behind a flag, an approach okay with @bmeck in #15566 (comment).
|
I’m ok for a flag too. |
|
A flag it is then! |
3 tasks
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Apr 14, 2018
TimothyGu
added a commit
that referenced
this pull request
Apr 18, 2018
PR-URL: #19604 Refs: #17807 Refs: #15566 (comment) Reviewed-By: Gus Caplan <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
PR-URL: #19604 Refs: #17807 Refs: #15566 (comment) Reviewed-By: Gus Caplan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #15566
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps, test, repl