Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change callback function to arrow function #17697

Closed
wants to merge 1 commit into from
Closed

test: change callback function to arrow function #17697

wants to merge 1 commit into from

Conversation

routerman
Copy link
Contributor

I'd like to send pull request on nodejs.
I replaced function with arrow in test/parallel/test-http-default-encoding.js.

I'm working on this issues
nodejs/code-and-learn#77

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 15, 2017
@gireeshpunathil
Copy link
Member

@routerman - your email id is not associated with this commit, please configure
git config --global user.email and git config --global user.name

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 15, 2017
@routerman
Copy link
Contributor Author

@gireeshpunathil I've just added right email address which should be associated with this commit. is it ok? Thank you. :)

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12133/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 15, 2017
@BridgeAR
Copy link
Member

Landed in 604578f

@BridgeAR BridgeAR closed this Dec 15, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 15, 2017
@routerman @BridgeAR
test: change callback function to arrow function
604578f 
PR-URL: nodejs#17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

@routerman congratulations on your first commit to Node.js! 🎉

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@routerman @MylesBorins
test: change callback function to arrow function
b37318c 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@routerman @MylesBorins
test: change callback function to arrow function
bc45354 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@routerman @MylesBorins
test: change callback function to arrow function
15a1551 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@routerman @MylesBorins
test: change callback function to arrow function
e63ad6b 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@routerman @gibfahn
test: change callback function to arrow function
d4f355a 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@routerman @MylesBorins
test: change callback function to arrow function
a23e47b 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@routerman @MylesBorins
test: change callback function to arrow function
bab85cf 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@routerman @MylesBorins
test: change callback function to arrow function
cc03470 
PR-URL: #17697
Reviewed-By: Yosuke Furukawa <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@maclover7 maclover7 maclover7 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@yosuke-furukawa yosuke-furukawa yosuke-furukawa approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@routerman @gireeshpunathil @maclover7 @BridgeAR @yosuke-furukawa @cjihrig @tniessen @MylesBorins @addaleax @nodejs-github-bot