lib: add space to class string of iterator objects and updated tests accordingly #17558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent resulting make errors in test files
…vent resulting make errors in test files
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
|
Hello, @haejinjo! Welcome, and thanks for this PR! It looks like you checked in three files that are backup files from your editor. These are the files with names that end with |
Using the command find -name "*~" I identified which files in my branch were unnecessary (denoted by the ~ ending in their filename) and removed them from their respective directories in test and lib.
Using the command find -name "*~" I identified which files in my branch were unnecessary (denoted by the ~ ending in their filename) and removed them from their respective directories in test and lib.
|
Thank you @Trott! I didn't know it was bad to have backup files. Is it just to keep the directory clean and orderly, or do they have more serious risks than is immediately apparent? Anyway, hope everything checks out now! Let me know. |
|
i think he meant that having backups is good, but they don't really belong in the repo 😄 |
apapirovski
approved these changes
Dec 12, 2017
apapirovski
added
the
author ready
|
Hi @haejinjo — could you try to get rid of the merge commit in here and rebase without it? Otherwise we can't run the CI and land this. |
apapirovski
removed
the
author ready
jasnell
approved these changes
Dec 12, 2017
addaleax
added
author ready
|
CI (without rebasing): https://ci.nodejs.org/job/node-test-commit/14785/ It should be fine if whoever lands this takes care of rebasing the merge commit out |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 13, 2017
PR-URL: nodejs#17558 Fixes: nodejs#17540 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 486290b 🎉 Thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Dec 13, 2017
PR-URL: #17558 Fixes: #17540 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
removed
the
author ready
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
PR-URL: #17558 Fixes: #17540 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #17558 Fixes: #17540 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
PR-URL: #17558 Fixes: #17540 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
PR-URL: #17558 Fixes: #17540 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserted a space in the string descriptor for URLSearchParamsIterator
in the URL parser API so that it became URLSearchParams Iterator
according to recent changes in the standards.
Sorry I didn't realize my commit message was bad until I read
the guidelines.
Fixes: #17540
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib