Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick b8331cc030 from upstream V8 #16900

Closed
wants to merge 1 commit into from

Commits on Nov 9, 2017

  1. deps: cherry-pick b8331cc030 from upstream V8

    Original commit message:
    
        I believe the paths to the V8 include headers are incorrect. The
        paths to other sources seem to be relative to the parent directory.
    
        When building Node.js I get the following warning on Windows:
        Warning: Missing input files:
        deps\v8\src\..\..\include\v8-inspector-protocol.h
        deps\v8\src\..\..\include\v8-inspector.h
    
        This commit updates the two include paths.
    
        Bug:
        Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f
        Reviewed-on: https://chromium-review.googlesource.com/743981
        Reviewed-by: Aleksey Kozyatinskiy <[email protected]>
        Commit-Queue: Aleksey Kozyatinskiy <[email protected]>
        Cr-Commit-Position: refs/heads/master@{nodejs#49121}
    
    This commit also increments the v8_embedder_string version.
    
    Fixes: nodejs#16614
    Refs: v8/v8@b8331cc
    danbev committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    a15f113 View commit details
    Browse the repository at this point in the history