remove message from test assertion #16819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert message in strictEqual was hiding error why test has failed, it just showed what value is expected and in case of failure we want to know which value has caused test to fail
cjihrig
approved these changes
Nov 6, 2017
mscdex
added
the
child_process
gireeshpunathil
added
the
code-and-learn
gireeshpunathil
approved these changes
Nov 6, 2017
apapirovski
approved these changes
Nov 6, 2017
|
CI stalled oddly. Re-running. |
Trott
approved these changes
Nov 7, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: nodejs#16819 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 9e4fa6c. |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: nodejs#16819 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: #16819 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: #16819 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: #16819 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: #16819 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert message in strictEqual was hiding error why test has failed, it
just showed what value is expected and in case of failure we want to
know which value has caused test to fail
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)